This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, build] Re-add support for 32-bit simulators (i386) #11891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
approved these changes
May 11, 2018
platform/ios/CHANGELOG.md
Outdated
| @@ -4,10 +4,14 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT | |||
|
|
|||
| ## 4.0.1 | |||
|
|
|||
| ### Packaging | |||
|
|
|||
| * Re-added support for 32-bit simulators (i386) to avoid conflicts with CocoaPods. ([#11891](https://github.com/mapbox/mapbox-gl-native/pull/11891)) | |||
There was a problem hiding this comment.
Maybe word it more strongly, like “to work around an issue in CocoaPods”, since it doesn’t seem to be a bug on our end?
friedbunny
force-pushed
the
fb-never-gonna-give-i386-up
branch
from
20f88d8
to
0d067e3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the removal of
i386slices from our framework in #10962/ios-v4.0.0. This is because CocoaPods effectively forces pods to packagei386in all of their dependencies (e.g., mapbox/mapbox-navigation-ios#1394).This puts us back at the
ios-v3.7.xstate, where we stripi386from dSYMs only (#10781)./cc @bsudekum @1ec5 @akitchen @fabian-guerra