Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Prepare for more DefaultFileSource changes #12072

Merged
merged 9 commits into from
Jun 12, 2018
Merged

Prepare for more DefaultFileSource changes #12072

merged 9 commits into from
Jun 12, 2018

Commits on Jun 12, 2018

  1. [test] pull out using namespace mbgl to reduce verbosity

    @kkaefer
    kkaefer committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    77cf898 View commit details
    Browse the repository at this point in the history

  2. [test] standardize on database file name and move I/O functions to util

    @kkaefer
    kkaefer committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    9709e72 View commit details
    Browse the repository at this point in the history

  3. [test] add partial message matching support to FixtureLog

    @kkaefer
    kkaefer committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    45b196b View commit details
    Browse the repository at this point in the history

  4. [core] allow logging error codes and formatting strings at the same time

    @kkaefer
    kkaefer committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    b12a177 View commit details
    Browse the repository at this point in the history

  5. [core] send all SQLite log messages to the Info bucket and add error … 

    …codes
    @kkaefer
    kkaefer committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    432b559 View commit details
    Browse the repository at this point in the history

  6. [test] verify log messages of OfflineDatabase tests

    @kkaefer
    kkaefer committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    b0f24a9 View commit details
    Browse the repository at this point in the history

  7. [core] support moving Database object during a Transaction

    @kkaefer
    kkaefer committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    06bb3ae View commit details
    Browse the repository at this point in the history

  8. [core] remove unused flags from SQLite header

    @kkaefer
    kkaefer committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    56cf8e7 View commit details
    Browse the repository at this point in the history

  9. [core] consolidate database opening workflow 

    Before this change, we've tried to open the database in read/write, but not create mode. In situations where the database didn't exist yet, this logged an error to the console, and we proceeded to opening it again in read/write/create mode, which actually created the file. The reason we did this is so that we could detect really old caching databases from January 2016 in case a developer upgraded from an older SDK (iOS v3.1 and earlier, Android v3.2 and earlier) that didn't have #3715 yet.

However, these error messages, while innocent, look scary in the console and some users suspect that it's a bug. This change opens the file directly in read/write/create mode, omitting the first failed attempt. To handle old cache databases, we're now deleting the `http_cache` table, which was the only table in those old databases, and create the new schema, rather than deleting the entire file and recreating the Database object. In most scenarios, this will lead to one fewer opening attempt, while the database migration will continue to work for the few users who upgrade all the way from a January 2016 SDK.

Additionally, this fixes a mismatch between the Qt and non-Qt implementation: Qt doesn't support opening a file in read/write mode without the create flag. This means that we've seen a different control flow on Qt compared to the non-Qt implementation when opening a database.
    @kkaefer
    kkaefer committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    4b7ec06 View commit details
    Browse the repository at this point in the history