This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Affix user dot on screen in user tracking mode #3589
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
453000a
[ios] Affix user dot on screen in user tracking mode
1ec5 41ce7b2
[ios] Fly to user location
1ec5 51be461
[ios] Leave user location callout open when tracking
1ec5 2519255
[ios] Eliminated jump after flight to first location
1ec5 867e015
[ios] Maintain user tracking mode after orientation change
1ec5 59f2c53
[ios] Keep callout attached to moving user dot
1ec5 35895af
[ios] Keep user dot callout open after user location change
1ec5 a93e7d7
[ios] Non-animated user tracking mode changes
1ec5 07c4c54
[ios] Made user dot position configurable
1ec5 65f6eb2
[ios, osx] Optionally animate content insets change
1ec5 5a00427
[ios] Maintain user tracking, anchor on user dot during zoom, rotate
1ec5 bd46111
[ios] Reset user tracking, respect content inset in resetPosition
1ec5 460b21e
[ios] z14 initially in user tracking mode
1ec5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[ios] Keep user dot callout open after user location change
Outside of user tracking mode, the user dot moves in spurts, so view synchronization performance isn’t an issue.
- Loading branch information
commit 35895af5d4b01b1f0f9a035359225554495f2786
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means we potentially drop a fresher location if the old transition is still in progress?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only for the transition to the initial location when user tracking is switched on. That transition may take longer than a second and shouldn't be interrupted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first location is also likely to be relatively inaccurate and get preempted quickly by another update. Don't think this is a blocker here, just another reason to do #3610.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MapKit does a simple, easeTo-style animation to the first location, which makes it easier to accommodate intervening updates. By contrast, this branch uses a Google-style flyTo, which wouldn't be easy to modify mid-flight even after implementing #3610.
In their own ways, both MapKit and Google Maps favor context and continuity over up-to-the-second precision. If a particular application needs to go immediately to the actual user location, it can pass NO into -setUserTrackingMode:animated:, which is being made public in this PR.