Simplified Chinese localization #7316

YunjieLi · 2016-12-07T00:34:42Z

Per chat w/ @1ec5 adding the Chinese localization.

mention-bot · 2016-12-07T00:34:44Z

@YunjieLi, thanks for your PR! By analyzing this pull request, we identified @1ec5, @boundsj and @friedbunny to be potential reviewers.

YunjieLi · 2016-12-07T00:40:46Z

A few notes:

didn't touch the .stringsdict since they're not needed for Chinese.
left out two strings that look like error messages in localizable.strings.
Not sure what this means "MAP_A11Y_VALUE" = "Zoom %1$dx\n%2$ld annotation(s) visible";
telemetry is 传感数据 according to @xinnong
used 你 not 您 (like tu vs. vous in French) for you to make it sound more friendly and less businesslike

friedbunny · 2016-12-07T02:03:37Z

platform/ios/resources/zh-Hans.lproj/Localizable.strings

+"COMPASS_A11Y_LABEL" = "指南针";
+
+/* Compass abbreviation for north */
+"COMPASS_NORTH" = "N";


This string is the text that is displayed at the top of the compass image. Apple Maps uses 北 for Chinese/Japanese (and I’m likely to do the same when we add a Japanese localization to this SDK) — any objections to us using 北 in Chinese, too?

I personally prefer N for brevity but no objections!

北 fits and is consistent with MapKit’s Chinese localizations, so let’s go with that.

1ec5

The translations appear to be consistent with CLDR and the Chinese Wikipedia.

Would you do the honors and mention the new Simplified Chinese localization in the relevant section of platform/ios/CHANGELOG.md and platform/macos/CHANGELOG.md?

1ec5 · 2016-12-07T10:35:44Z

platform/ios/app/Assets.xcassets/AppIcon.appiconset/Contents.json

@@ -1,6 +1,16 @@
 {
  "images" : [
    {
+      "idiom" : "iphone",


These changes look unrelated. If they’re needed, would you mind splitting them out into a separate PR? Thanks.

I did not make that change manually. can I just revert the changes manually?

1ec5 · 2016-12-07T10:40:38Z

platform/darwin/resources/zh-Hans.lproj/Foundation.stringsdict

+	<key>COORD_DEG_LONG</key>
+	<dict>
+		<key>NSStringLocalizedFormatKey</key>
+		<string>%#@degrees@</string>


Since Chinese doesn’t need to pluralize any strings, leave this file out so Chinese speakers don’t see English. COORD_DEG_LONG etc. are already defined in Localizable.strings.

1ec5 · 2016-12-07T10:43:32Z

platform/ios/resources/zh-Hans.lproj/Localizable.strings

+"FIRST_STEPS_URL" = "mapbox.com/help/first-steps-ios-sdk";
+
+/* Accessibility hint */
+"INFO_A11Y_HINT" = "显示致谢，用户反馈及更多";


Should the list items be separated by ， or 、?

1ec5 · 2016-12-07T10:45:53Z

platform/ios/resources/zh-Hans.lproj/Localizable.strings

+"MAP_A11Y_LABEL" = "地图";
+
+/* Map accessibility value */
+"MAP_A11Y_VALUE" = "Zoom %1$dx\n%2$ld annotation(s) visible";


After the user zooms the map, VoiceOver says, for example:

Zoom 2x
12 annotations visible

%1d is a placeholder for the zoom scale (but x is pronounced literally in English). \n is a newline. %2$ld is a placeholder for the number of visible annotations.

If “annotations” doesn’t translate well, you can try something like “pins”, “markers”, or “map items”.

1ec5 · 2016-12-07T10:47:45Z

platform/ios/resources/zh-Hans.lproj/Localizable.stringsdict

+	<key>MAP_A11Y_VALUE</key>
+	<dict>
+		<key>NSStringLocalizedFormatKey</key>
+		<string>Zoom %dx


Likewise, you can leave this file out too.

1ec5 · 2016-12-07T10:54:30Z

platform/ios/resources/zh-Hans.lproj/Localizable.strings

+"ANNOTATION_A11Y_HINT" = "显示信息";
+
+/* No comment provided by engineer. */
+"API_CLIENT_400_DESC" = "The session data task failed. Original request was: %@";


These error messages come from Mapbox Telemetry. In general, error messages should be translated whenever possible. However, in this case, they aren’t ever presented to the user, so it’s fine to leave these messages in English.

1ec5 · 2016-12-07T10:56:44Z

platform/ios/resources/zh-Hans.lproj/Localizable.strings

+"COMPASS_A11Y_LABEL" = "指南针";
+
+/* Compass abbreviation for north */
+"COMPASS_NORTH" = "N";


北 fits and is consistent with MapKit’s Chinese localizations, so let’s go with that.

1ec5 · 2016-12-07T11:00:35Z

This PR is targeted at the master branch. It’s probably too late to take this PR for v3.4.0, but I think we could get it into v3.4.1 as long as we rebase the branch and retarget the PR upon the release-ios-v3.4.0 branch.

YunjieLi · 2016-12-09T00:58:13Z

@friedbunny @1ec5 just incorporated the feedbacks above. Want to take another look?

friedbunny

Thanks!

1ec5 · 2016-12-09T17:49:11Z

platform/macos/CHANGELOG.md

@@ -5,6 +5,7 @@
 * Labels written in Arabic, Hebrew, and other scripts are written right-to-left. Arabic characters are correctly shaped. ([#6984](https://github.com/mapbox/mapbox-gl-native/pull/6984), [#7123](https://github.com/mapbox/mapbox-gl-native/pull/7123))
 * Improved the line wrapping behavior of point-placed labels written in Chinese, Japanese, and Yi. ([#6828](https://github.com/mapbox/mapbox-gl-native/pull/6828))
 * Fixed an issue where translucent point annotations along tile boundaries would be drawn darker than expected. ([#6832](https://github.com/mapbox/mapbox-gl-native/pull/6832))
+* Added the Simplified Chinese localization. ([#7316](https://github.com/mapbox/mapbox-gl-native/pull/7316))


I just realized this PR doesn’t actually localize the macOS SDK. It could – you’d add the localization to macos.xcodeproj, reuse platform/darwin/resources/zh-Hans.lproj/Foundation.strings, and add platform/macos/resources/zh-Hans.lproj/Localizable.strings (just 10 easy strings). But we can take care of that in a separate PR. Would you mind removing this changelog entry in the meantime?

friedbunny · 2016-12-09T21:29:11Z

Oh, sorry, we forgot to mention one thing: because this is such a busy repo with so many different platforms, we prefix commits messages with the affected platforms. E.g., [ios] Added super-awesome localization.

Just something to keep in mind for next time. 👍

YunjieLi · 2016-12-10T00:46:54Z

Roger that @friedbunny

1ec5 · 2016-12-10T03:16:09Z

Opened #7370 for a Traditional Chinese localization based on this one and #7371 for a Simplified Chinese localization in the macOS SDK.

translated into Chinese

aa420f3

friedbunny reviewed Dec 7, 2016

View reviewed changes

1ec5 approved these changes Dec 7, 2016

View reviewed changes

1ec5 added Google Maps parity For feature parity with the Google Maps SDK for Android or iOS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS MapKit parity For feature parity with MapKit on iOS or macOS labels Dec 7, 2016

1ec5 changed the title ~~Chinese localization~~ Simplified Chinese localization Dec 7, 2016

1ec5 added this to the ios-3.4.1 milestone Dec 7, 2016

1ec5 added the localization Human language support and internationalization label Dec 7, 2016

YunjieLi added 2 commits December 8, 2016 16:30

light edits to translations

ece1e2b

update two changelogs; remove .stringsdict files

cfd6f06

friedbunny approved these changes Dec 9, 2016

View reviewed changes

1ec5 removed the macOS Mapbox Maps SDK for macOS label Dec 9, 2016

1ec5 reviewed Dec 9, 2016

View reviewed changes

1ec5 modified the milestones: ios-v3.5.0, ios-3.4.1 Dec 9, 2016

remove update from macos changelog

5386895

YunjieLi merged commit ffd74c3 into master Dec 9, 2016

friedbunny deleted the local-zh branch December 9, 2016 21:24

This was referenced Dec 9, 2016

Traditional Chinese localization #7370

Closed

Simplified Chinese localization #7371

Closed

1ec5 mentioned this pull request Dec 21, 2016

Add Simplified Chinese localization #7503

Merged

1ec5 mentioned this pull request Jan 30, 2017

Traditional Chinese localization #7899

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplified Chinese localization #7316

Simplified Chinese localization #7316

YunjieLi commented Dec 7, 2016

mention-bot commented Dec 7, 2016

YunjieLi commented Dec 7, 2016

friedbunny Dec 7, 2016

YunjieLi Dec 7, 2016

1ec5 Dec 7, 2016

1ec5 left a comment

1ec5 Dec 7, 2016

YunjieLi Dec 9, 2016 •

edited

Loading

1ec5 Dec 9, 2016

1ec5 Dec 7, 2016

1ec5 Dec 7, 2016

1ec5 Dec 7, 2016

1ec5 Dec 7, 2016

1ec5 Dec 7, 2016

1ec5 Dec 7, 2016

1ec5 commented Dec 7, 2016

YunjieLi commented Dec 9, 2016

friedbunny left a comment

1ec5 Dec 9, 2016

1ec5 Dec 10, 2016

friedbunny commented Dec 9, 2016

YunjieLi commented Dec 10, 2016

1ec5 commented Dec 10, 2016

Simplified Chinese localization #7316

Simplified Chinese localization #7316

Conversation

YunjieLi commented Dec 7, 2016

mention-bot commented Dec 7, 2016

YunjieLi commented Dec 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YunjieLi Dec 9, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 commented Dec 7, 2016

YunjieLi commented Dec 9, 2016

friedbunny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

friedbunny commented Dec 9, 2016

YunjieLi commented Dec 10, 2016

1ec5 commented Dec 10, 2016

YunjieLi Dec 9, 2016 •

edited

Loading