Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Make MGLOpenGLStyleLayer.h public in static library #7844

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jan 25, 2017

Made MGLOpenGLStyleLayer.h public in the static library, fixing a build error that occurred in applications that linked against the static framework.

This issue slipped under our radar through a combination of factors:

  • We don’t build an application that links against the static library on Bitrise, or the static library itself for that matter.
  • jazzy warns about any symbols declared in the table of contents but left undefined in the framework. However, as of Insert example code in original headers #7569, we point jazzy to the checked-in headers rather than the built static library headers (which omitted MGLOpenGLStyleLayer.h).
  • After building the release, I tested linking the dynamic framework into an application but not the static framework.

/cc @kkaefer

@1ec5 1ec5 added build iOS Mapbox Maps SDK for iOS release blocker Blocks the next final release labels Jan 25, 2017
@1ec5 1ec5 added this to the ios-v3.4.1 milestone Jan 25, 2017
@1ec5 1ec5 self-assigned this Jan 25, 2017
@1ec5 1ec5 requested a review from friedbunny January 25, 2017 07:29
@mention-bot
Copy link

@1ec5, thanks for your PR! By analyzing this pull request, we identified @boundsj, @incanus and @friedbunny to be potential reviewers.

@1ec5 1ec5 merged commit 4394c23 into release-ios-v3.4.0 Jan 25, 2017
@1ec5 1ec5 deleted the 1ec5-opengl-layer-public branch January 25, 2017 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS release blocker Blocks the next final release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants