This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
7955 fix MGLMapView leaks MGLReachability objects (and threads) #7956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielmatzke, thanks for your PR! By analyzing this pull request, we identified @1ec5, @jfirebaugh and @boundsj to be potential reviewers. |
1ec5
reviewed
Feb 6, 2017
There was a problem hiding this comment.
Thanks for the issue and PR! It looks like the iOS implementation of MGLMapView does exactly the same thing with the reachability object – would you mind fixing that implementation as well? Also, would you do the honors and add a brief note to the macOS and iOS changelogs about this fix? Thanks again.
|
Thanks for the quick response. I just uploaded an similar fix for the iOS MGLMapView. I verified that the fix compiles but did not test it in an app. |
1ec5
force-pushed
the
7955-MGLReachability-leaks
branch
from
ba751c3
to
2d38c17
Compare
1ec5
approved these changes
Feb 7, 2017
1ec5
added a commit
that referenced
this pull request
Feb 9, 2017
1ec5
added a commit
that referenced
this pull request
Feb 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #7955