This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
fixes #8522: don't alter tint color on annotation views #8789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boundsj
approved these changes
Apr 21, 2017
There was a problem hiding this comment.
Thanks! Looks good to me!
Reminder to use the "[{platform}] {message}" convention in commit titles. Tagging this PR itself with "Fixes #{issue_number}" will trigger GitHub to close the original issue when this PR lands. It'll also make GH notifications a bit more manageable.
jmkiley
approved these changes
Apr 21, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a simple and performant pointer equality test to bail early on view hierarchy recursion so as to not accidentally alter user-defined tint colors.
Not applicable to macOS.
/cc @jmkiley @boundsj