Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libtiledquick #2867

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Add libtiledquick #2867

merged 1 commit into from
Jul 19, 2020

Conversation

mitchcurtis
Copy link
Contributor

This moves the C++ types out of tiledquickplugin into a standalone
library so that other projects can link to them.

@mitchcurtis mitchcurtis force-pushed the libtiledquick branch 2 times, most recently from 331197f to f7b3132 Compare July 18, 2020 15:04
Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great! Please see inline comments for some nitpicks.

src/libtiledquick/libtiledquick.qbs Outdated Show resolved Hide resolved
src/libtiledquick/libtiledquick.qbs Outdated Show resolved Hide resolved
src/libtiledquick/libtiledquick.qbs Outdated Show resolved Hide resolved
This moves the C++ types out of tiledquickplugin into a standalone
library so that other projects can link to them.
@bjorn bjorn merged commit 1d005ed into mapeditor:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants