Add animation advancing to tmxrasterizer #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn
reviewed
Jul 19, 2020
|
@bjorn Thanks for the comments and suggestions. I have incorporated all changes. I don't really have a good C++ dev environment set up, so I let a number of those code styles get through, but thank you for catching them. |
|
@sballew Thanks again for this nice idea and for submitting the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1433 .
Objective
Allow a user to advance animations by a duration prior to rasterizing an image via tmxrasterizer.
Reasoning
This is an alternative to GIF support. A user can script multiple tmxrasterizer commands, each advancing the animation. This results in multiple PNG files, which the user can stitch together with any GIF creation tool such as
imagemagick.Notes
This should work with worlds, as it includes the tile animation reset. However I have not yet tested it on an animated world.