Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bundle resets on redirector and add map to bundling widget's bundled mode #2291

Merged
merged 21 commits into from
May 12, 2024

Conversation

CollinBeczak
Copy link
Collaborator

@CollinBeczak CollinBeczak commented Mar 1, 2024

Resolves: #2222, #1845
Backend: maproulette/maproulette-backend#1107

Features included in this pr:

  1. The map will stay open when tasks are bundled.
  2. Bundle reset button for reviewers and mappers when they are working on a task that initially had a bundle.
  3. Other status's now visible on map. (This adds better context, and also allows allows the map to function as expected in the reviewer mode.

Bugs fixed:
1.
Bug: Multiple people were able to work on the same tasks threw bundling.
Solution: All tasks in the bundle will be locked when in task review or task completion settings.
2.
Bug: New bundle created a bundle object that would never get deleted.
Solution: New bundles will no longer persist when a user redirects away from a bundle, and will be broken back up into individual tasks.
3.
Bug: When a reviewer edited a bundle, but did not submit the bundle, any changes they made were still saved.
Solution: Bundles that are changed in review but are not submitted will be reset to their initial value if the reviewer redirects away.

New bundle. Bundle mode displaying only bundled tasks:
Screenshot 2024-03-08 at 6 24 56 PM

Existing bundle. Bundle mode displayed but actions disabled:
Screenshot 2024-03-08 at 6 26 08 PM

Existing bundle and reviewing. Bundle mode displayed but actions disabled:
Screenshot 2024-03-08 at 6 25 27 PM

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 5.86207% with 273 lines in your changes are missing coverage. Please review.

Project coverage is 23.44%. Comparing base (6435413) to head (5e66ac9).
Report is 13 commits behind head on main.

Files Patch % Lines
...c/components/HOCs/WithTaskBundle/WithTaskBundle.js 0.00% 53 Missing and 16 partials ⚠️
...nents/Widgets/TaskBundleWidget/TaskBundleWidget.js 0.00% 40 Missing and 10 partials ⚠️
...ents/Widgets/TaskBundleWidget/TaskMarkerContent.js 0.00% 28 Missing and 6 partials ⚠️
.../components/TaskAnalysisTable/TaskAnalysisTable.js 9.67% 22 Missing and 6 partials ⚠️
src/services/Task/Task.js 15.62% 22 Missing and 5 partials ⚠️
...ChallengeTaskClusters/WithChallengeTaskClusters.js 0.00% 13 Missing and 4 partials ⚠️
...ReviewNearbyTasksWidget/ReviewNearbyTasksWidget.js 0.00% 12 Missing and 3 partials ⚠️
...s/WithTaskClusterMarkers/WithTaskClusterMarkers.js 0.00% 6 Missing and 2 partials ⚠️
src/interactions/TaskCluster/AsMappableCluster.js 0.00% 6 Missing and 1 partial ⚠️
...Map/LassoSelectionControl/LassoSelectionControl.js 50.00% 3 Missing and 1 partial ⚠️
... and 8 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
- Coverage   23.59%   23.44%   -0.16%     
==========================================
  Files         648      648              
  Lines       22497    22653     +156     
  Branches     6944     7033      +89     
==========================================
+ Hits         5308     5310       +2     
- Misses      14366    14491     +125     
- Partials     2823     2852      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak marked this pull request as draft March 8, 2024 02:09
@CollinBeczak CollinBeczak marked this pull request as ready for review March 11, 2024 21:56
@CollinBeczak CollinBeczak marked this pull request as draft April 9, 2024 16:51
@CollinBeczak CollinBeczak marked this pull request as ready for review April 9, 2024 21:53
@CollinBeczak CollinBeczak changed the title add bundle resets on redirect add bundle resets on redirector and add map to bundling widget Apr 23, 2024
@CollinBeczak CollinBeczak changed the title add bundle resets on redirector and add map to bundling widget add bundle resets on redirector and add map to bundling widget's bundled mode Apr 23, 2024
@CollinBeczak CollinBeczak merged commit c149d16 into main May 12, 2024
5 checks passed
@CollinBeczak CollinBeczak deleted the add-bundle-resets branch May 12, 2024 02:29
@CollinBeczak CollinBeczak mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to remove a task by click on a marker on the map
2 participants