Skip to content

Commit

Permalink
doc: slightly relax 50 character rule
Browse files Browse the repository at this point in the history
Allow commit message first line to exceed 50 chars if necessary

PR-URL: nodejs#16523
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
jasnell committed Oct 29, 2017
1 parent 980ebd2 commit 1cdcab0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,8 @@ notes about [commit squashing](#commit-squashing)).
A good commit message should describe what changed and why.

1. The first line should:
- contain a short description of the change
- be 50 characters or less
- contain a short description of the change (preferably 50 characters or less,
and no more than 72 characters)
- be entirely in lowercase with the exception of proper nouns, acronyms, and
the words that refer to code, like function/variable names
- be prefixed with the name of the changed subsystem and start with an
Expand Down

0 comments on commit 1cdcab0

Please sign in to comment.