Skip to content

Commit

Permalink
fs: don't conflate data and callback in appendFile
Browse files Browse the repository at this point in the history
PR-URL: nodejs#11607
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
seishun committed Jun 10, 2017
1 parent df02f39 commit 208db56
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -1320,7 +1320,7 @@ fs.writeFileSync = function(path, data, options) {
};

fs.appendFile = function(path, data, options, callback) {
callback = maybeCallback(arguments[arguments.length - 1]);
callback = maybeCallback(callback || options);
options = getOptions(options, { encoding: 'utf8', mode: 0o666, flag: 'a' });

// Don't make changes directly on options object
Expand Down
7 changes: 7 additions & 0 deletions test/parallel/test-fs-append-file.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,13 @@ fs.open(filename5, 'a+', function(e, fd) {
});
});

// test that a missing callback emits a warning, even if the last argument is a
// function.
const filename6 = join(common.tmpDir, 'append6.txt');
const warn = 'Calling an asynchronous function without callback is deprecated.';
common.expectWarning('DeprecationWarning', warn);
fs.appendFile(filename6, console.log);

process.on('exit', function() {
assert.strictEqual(12, ncallbacks);

Expand Down

0 comments on commit 208db56

Please sign in to comment.