Skip to content

Commit

Permalink
Change the default remote_cache_warnings warnings behavior to `back…
Browse files Browse the repository at this point in the history
…off`. (pantsbuild#15745)

When we initially set this, we were concerned with error noise, but in practice the backoff setting gives a very reasonable amount of (desirable) output.

[ci skip-build-wheels]
[ci skip-rust]
  • Loading branch information
stuhood committed Jun 3, 2022
1 parent 8b91de4 commit 67f93a2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions pants.ci.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ colors = true

remote_cache_read = true
remote_cache_write = true
# We want to continue to get logs when remote caching errors.
remote_cache_warnings = "backoff"

[test]
use_coverage = true
Expand Down
4 changes: 2 additions & 2 deletions src/python/pants/option/global_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ def from_options(cls, options: OptionValueContainer) -> LocalStoreOptions:
remote_store_batch_api_size_limit=4194304,
# Remote cache setup.
remote_cache_eager_fetch=True,
remote_cache_warnings=RemoteCacheWarningsBehavior.first_only,
remote_cache_warnings=RemoteCacheWarningsBehavior.backoff,
remote_cache_rpc_concurrency=128,
remote_cache_read_timeout_millis=1500,
# Remote execution setup.
Expand Down Expand Up @@ -1349,7 +1349,7 @@ class BootstrapOptions:
advanced=True,
help=softwrap(
"""
Whether to log remote cache failures at the `warn` log level.
How frequently to log remote cache failures at the `warn` log level.
All errors not logged at the `warn` level will instead be logged at the
`debug` level.
Expand Down

0 comments on commit 67f93a2

Please sign in to comment.