This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
fix: correct usage for deploying commands #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscordJS documentation incorrectly tells people to use the "PUT" call. Discord's API "PUT" call will replace ALL commands that have been registered. Commands should be updated individually so as to not erase existing commands that are regisitered to the bot.
|
lgtm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiscordJS documentation incorrectly tells people to use the "PUT" call, which is okay if the discord bot runs in isolation. However, Discord's API Commands "PUT" call will replace ALL commands that have been registered. Commands should be updated individually so as to not erase existing commands that are registered to the bot.
Changes
Changes the deploySlashCommands.ts discord API call to asynchronously call discordJS's "rest.post" call for each command rather than using the "rest.put" for the entire set of commands. This way we don't erase commands added to the job from other bot applications running under the same token.