Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make autolinks case insensitive #1384

Merged
merged 3 commits into from
Dec 6, 2018
Merged

Make autolinks case insensitive #1384

merged 3 commits into from
Dec 6, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Dec 5, 2018

Marked version: master

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

Make urls case insensitive

implements #1350 (comment)

marked("hTtP://fOo.CoM");
// <p><a href=\"hTtP://fOo.CoM\">hTtP://fOo.CoM</a></p>

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@styfle
Copy link
Member

styfle commented Dec 5, 2018

/cc @roygold7 since PR 1350 was started but didn't finish.

I want to make sure Roy is aware of this PR and that the reason for the new PR is no movement on the old PR.

I don't want to end up in this scenario.

styfle and others added 2 commits December 5, 2018 12:12
Co-Authored-By: UziTech <tony@brix.ninja>
Co-Authored-By: UziTech <tony@brix.ninja>
@roygold7
Copy link

roygold7 commented Dec 5, 2018

@styfle I appreciate the comment but I'd be just as happy if the issue was resolved in a different PR. I'm not looking for credit.

@davisjam
Copy link
Contributor

davisjam commented Dec 6, 2018

LGTM. This should not have a ReDoS impact.

@styfle styfle changed the title Make links case insensitive Make autolinks case insensitive Dec 6, 2018
@styfle styfle merged commit 06297df into markedjs:master Dec 6, 2018
@UziTech UziTech deleted the url-case-insensitive branch February 19, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants