Test improvements #258
Merged
Test improvements #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbabker
force-pushed
the
improve-test-coverage
branch
3 times, most recently
from
f97afd2
to
ae1a457
Compare
mbabker
force-pushed
the
improve-test-coverage
branch
from
ae1a457
to
9436b01
Compare
|
Great work @mbabker !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts in some effort to improve the bundle's test coverage.
The biggest change is that the repository classes now use functional tests against a real database instance. This also helps with making sure the schema mappings are valid (which, they weren't for MongoDB). Beyond that, it's mostly filling in specs around some of the newer classes or covering the non-default and error-path behaviors in some classes.
This also bumps up some of the development dependencies to more recent minimums. Some of the minimums actually error out on the prefer minimum build for PHP 7.4, so these should be set to something that doesn't cause errors.