Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type docs and typehints #259

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jul 15, 2021

Three things here:

  1. For all public and protected symbols, adds doc blocks documenting supported types where they were missing
  2. For private symbols, adds typehints for with type information
  3. Adds the $datetime argument to RefreshTokenManagerInterface::revokeAllInvalid(), callers to the manager are already passing that argument so it's implicitly expected to be there anyway

@markitosgv markitosgv merged commit c752135 into markitosgv:master Jul 16, 2021
@mbabker mbabker deleted the type-docs branch August 23, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants