Fix SF 7 compat #366
Merged
Fix SF 7 compat #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbabker
commented
Nov 13, 2023
| @@ -298,6 +298,10 @@ public function testAttachesTheTokenToTheResponseBodyOnCredentialsAuth() | |||
|
|
|||
| public function testDoesNothingWhenThereIsNotAUser() | |||
| { | |||
| if ((new \ReflectionClass(AuthenticationSuccessEvent::class))->getMethod('getUser')->hasReturnType()) { | |||
There was a problem hiding this comment.
This check is necessary because the WIP lexik/jwt-authentication-bundle 3.x branch adds return types on this event class, and its getUser() method isn't documented as nullable in the first place. For now I just skip the test when that branch gets installed as it's the only failure when I force all dev dependencies to be pulled in (merging #338 as early as it was might've been premature given we don't look to be anywhere near a stable release yet).
|
lexik/LexikJWTAuthenticationBundle#1165 has just been merged 👍 |
mbabker
force-pushed
the
fix-sf-7
branch
5 times, most recently
from
a005f48
to
8222d03
Compare
|
Rebased, issues fixed, ready to go. |
|
👍 Nice one. Will be nice to see this merged! |
maxhelias
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Symfony 7 compat PR was merged and released too quickly, given that:
lexik/jwt-authentication-bundleitself has a pending PR for Symfony 7 supportsymfony/security-guardversions that do not exist to the Composer manifestThis PR is a draft PR until theIssues fixed and ready for review/merge.lexik/jwt-authentication-bundlePR is merged, as that will block the Symfony 7 build from running until it's merged/released.