Provide implicits automatically

marmbrus · Jun 18, 2015 · ae1896b · ae1896b
1 parent a80f9b0
commit ae1896b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/SortSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/SortSuite.scala
@@ -17,14 +17,9 @@
 
 package org.apache.spark.sql.execution
 
-import org.apache.spark.sql.catalyst.expressions.{BoundReference, Ascending, SortOrder}
 import org.apache.spark.sql.catalyst.dsl.expressions._
 
-import org.apache.spark.sql.test.TestSQLContext
-import org.apache.spark.sql.types.{IntegerType, StringType}
-
 class SortSuite extends SparkPlanTest {
-  import TestSQLContext.implicits.localSeqToDataFrameHolder
 
   test("basic sorting using ExternalSort") {
 

diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanTest.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanTest.scala
@@ -17,8 +17,9 @@
 
 package org.apache.spark.sql.execution
 
-import scala.util.control.NonFatal
+import scala.language.implicitConversions
 import scala.reflect.runtime.universe.TypeTag
+import scala.util.control.NonFatal
 
 import org.apache.spark.SparkFunSuite
 
@@ -27,14 +28,21 @@ import org.apache.spark.sql.catalyst.expressions.BoundReference
 import org.apache.spark.sql.catalyst.util._
 
 import org.apache.spark.sql.test.TestSQLContext
-import org.apache.spark.sql.{Row, DataFrame}
+import org.apache.spark.sql.{DataFrameHolder, Row, DataFrame}
 
 /**
  * Base class for writing tests for individual physical operators. For an example of how this
  * class's test helper methods can be used, see [[SortSuite]].
  */
 class SparkPlanTest extends SparkFunSuite {
 
+  /**
+   * Creates a DataFrame from a local Seq of Product.
+   */
+  implicit def localSeqToDataFrameHolder[A <: Product : TypeTag](data: Seq[A]): DataFrameHolder = {
+    TestSQLContext.implicits.localSeqToDataFrameHolder(data)
+  }
+
   /**
    * Runs the plan and makes sure the answer matches the expected result.
    * @param input the input data to be used.