Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <PrevNextButtons> index when using paginated results #10144

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Aug 14, 2024

Problem

Fix #10136

Solution

Fix the index computation in case the data comes from the query cache and page > 1

How To Test

The fix can be tested in Storybook or in the E-commerce Demo

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date -> no need

Also, please make sure to read the contributing guidelines.

@slax57 slax57 added this to the 5.1.2 milestone Aug 14, 2024
@slax57 slax57 merged commit 22dae61 into master Aug 14, 2024
1 of 2 checks passed
@slax57 slax57 deleted the fix-PrevNextButtons-pagination-index branch August 14, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect index display in PrevNextButtons component on pagination navigation
1 participant