Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add ra-data-nestjs-query to the list of Data Providers #10145

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

mrnkr
Copy link
Contributor

@mrnkr mrnkr commented Aug 14, 2024

Problem

There was no Nestjs-query data provider available.

Solution

I wrote one and added it to the list of supported backends.

Screenshot 2024-08-14 at 12 26 04 PM

How To Test

https://github.com/marmelab/react-admin?tab=readme-ov-file#documentation-1

Serve the documentation like it is suggested in the README.md file and look at the DataProviderList.md file. There should be 3 GraphQL data providers in the list, with the last one being the one I added.

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why) (N/A)
  • The PR includes one or several stories (if not possible, describe why) (N/A)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙂

Although your dataProvider is based on ra-data-graphql, I figured it would be better placed next to the NestJS CRUD dataProvider.

I also took the liberty to add the logo.

@slax57 slax57 added this to the 5.1.2 milestone Aug 16, 2024
@slax57 slax57 merged commit 4d96a3b into marmelab:master Aug 16, 2024
1 of 2 checks passed
@slax57 slax57 changed the title [DOCS] Add ra-data-nestjs-query to DataProviderList.md [Doc] Add ra-data-nestjs-query to DataProviderList.md Aug 16, 2024
@fzaninotto fzaninotto changed the title [Doc] Add ra-data-nestjs-query to DataProviderList.md [Doc] Add ra-data-nestjs-query to the list of Data Providers Aug 19, 2024
@fzaninotto fzaninotto changed the title [Doc] Add ra-data-nestjs-query to the list of Data Providers [Doc] Add ra-data-nestjs-query to the list of Data Providers Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants