-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Edit toolbar hides the last form item on mobile #2466
Conversation
making bottom padding for last child to be 70px for xs media size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! Can you add a screenshot ?
}; | ||
'&:last-child': { | ||
paddingBottom: 16, | ||
// Reset on mouse devices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this comment? It does not bring anything as the code is clear enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still like a screenshot please :)
@djhi screenshot of before and after? |
Thanks! I'll wait for @fzaninotto review though |
There is something wrong with your screenshot: the action buttons should not appear above the Save button. Is is a side effect of your change? |
@fzaninotto this is just my custom form control from Advanced Tutorials |
just see what is going on on mobile view without custom controls... it is broken |
Thanks! |
making bottom padding for last child to be 70px for xs media size
Fix #2463