[RFR] Add types to side effects #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
reviewed
Nov 15, 2018
| } from '../../../../actions/listActions'; | ||
| import { CRUD_DELETE_OPTIMISTIC } from '../../../../actions/dataActions'; | ||
|
|
||
| const initialState = []; | ||
|
|
||
| export default (previousState = initialState, action) => { | ||
| type State = any[]; |
There was a problem hiding this comment.
I think every reducer should probably export its state definition and we should make a complete state definition by composing all of them in the root types.ts file
There was a problem hiding this comment.
I think that combineReducer does it. Let's wait until the main reducer is migrated to TS to see.
There was a problem hiding this comment.
As discussed, yes, but that won't allow our users to have a typed state in their mapStateToDispatch functions
There was a problem hiding this comment.
I'll export the states in a future PR
djhi
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the ongoing effort to add TypeScript support to ra-core