Add allowDuplicates property to AutocompleteArrayInput and fix #2311

[tiagoschenkel]

The method handleSuggestionSelected is adding the new value directly to the input through onChange method. Even when the property allowDuplicates is enabled in the AutocompleteArrayInputChip this element will be added.

This merge request adds a new property to AutocompleteArrayInput component, named allowDuplicates, that is used to allow or disallow insertion of duplicated elements.

Fixes #2311

[djhi]

Great 👍 Would you mind adding some tests though ?

[tiagoschenkel]

Hi @djhi,

I could write some unit tests, but this would take more time.

Do you have in mind any specific test case?

For me is not 100% clear yet if this allowDuplicates property is a feature or a bug.

Yes, I'm adding a new property thinking about keeping backward compatibility, but them this flag should be disabled by default since the current behavior of the AutocompleteArrayInput is to not filter out duplicates.

My question is, does it make sense to add a new flag as a feature? Or should be the case that this is not intended behavior, then we should handle this as a bug and simply get rid of duplicated elements without having to add a new flag.

Got it?

Best!

[djhi]

Do you have in mind any specific test case?

That it allows or not allows duplicates depending on the allowDuplicates prop ?

My question is, does it make sense to add a new flag as a feature? Or should be the case that this is not intended behavior, then we should handle this as a bug and simply get rid of duplicated elements without having to add a new flag.

I'm sure there are cases where you want to allow duplicates so I think it's good to have a flag and it should be false by default

[tiagoschenkel]

@djhi,

I'm trying to simulate an onSuggestionSelectedevent from Autosuggest component, to validate if the onChange method will be called or not based in the allowDuplicates property.

I'm not able to force a select event, so the inputValue state property is never changing.

My last two test cases are incomplete even when they are passing.

Could you help with this?

[fzaninotto]

Superseded by #4026