Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Pluralize the confirmation message in BulkDeleteWithConfirmButton #3058

Merged
merged 1 commit into from
Mar 26, 2019
Merged

[RFR] Pluralize the confirmation message in BulkDeleteWithConfirmButton #3058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ra-ui-materialui/src/button/BulkDeleteWithConfirmButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class BulkDeleteWithConfirmButton extends Component {
translateOptions={{
smart_count: selectedIds.length,
name: inflection.humanize(
inflection.singularize(resource),
inflection.inflect(resource, selectedIds.length),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do even better. Many of users actually provide translations for their resources names. We should use them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #3040

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but this should be done across all messages. Let's merge @Luwangel's PR and do that in another PR.

true
),
}}
Expand Down