Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Prevent Event propagation after Delete Confirm modal close #3360

Merged
merged 2 commits into from
Jun 25, 2019
Merged

[RFR] Prevent Event propagation after Delete Confirm modal close #3360

merged 2 commits into from
Jun 25, 2019

Conversation

Kmaschta
Copy link
Contributor

Fixes #3359

When the DeleteWithConfirm modal was closed, it behaved like we clicked
on the Datagrid row (triggering the rowClick handler of Datagrid)

@Kmaschta
Prevent Event propagation after Delete Confirm modal close
93b8d7d 
Fixes #3359
When the DeleteWithConfirm modal was closed, it behaved like we clicked
on the Datagrid row (triggering the `rowClick` handler of Datagrid)
@Kmaschta Kmaschta added this to the 2.9.4 milestone Jun 25, 2019
@fzaninotto fzaninotto merged commit b8575cd into master Jun 25, 2019
@fzaninotto fzaninotto deleted the prevent-rowclick-on-confirm branch June 25, 2019 18:03
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.4
Development

Successfully merging this pull request may close these issues.

When canceling an operation, the DeleteButton button raises the rowClick event
3 participants
@Kmaschta @fzaninotto @djhi