Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Remove DisabledInput #3549

Merged
merged 3 commits into from
Aug 21, 2019
Merged

[RFR] Remove DisabledInput #3549

merged 3 commits into from
Aug 21, 2019

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Aug 20, 2019 •
edited
Loading

  • Remove the component
  • Update docs
  • Upgrade guide

@djhi djhi added this to the 3.0.0 milestone Aug 20, 2019
@fzaninotto
Copy link
Member

I can't find the readOnly prop in the material-ui documentation for TextField. It seems it's called disabled. Am I missing something?

https://material-ui.com/api/text-field/

@djhi
Copy link
Contributor Author

djhi commented Aug 21, 2019

You're right, according to mui documentation it should be:

InputProps={{
     readOnly: true,
}}

@fzaninotto
Copy link
Member

But doesn't the disabled prop suffice?

@djhi
Copy link
Contributor Author

djhi commented Aug 21, 2019

disabled !== readonly semantically.

Besaides, disabled inputs won't even be sent in the form payload.

@fzaninotto
Copy link
Member

The question is: is it our job to document this subtle distinction? Or should we encourage the simplest way (in my mind, disabled)?

@djhi djhi changed the title [WIP] Remove DisabledInput [RFR] Remove DisabledInput Aug 21, 2019
@fzaninotto fzaninotto merged commit e069b0e into next Aug 21, 2019
@fzaninotto fzaninotto deleted the remove-disabled-input branch August 21, 2019 12:55
@fzaninotto fzaninotto mentioned this pull request Aug 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @fzaninotto