[RFR] List perf improvements #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Aug 22, 2019
| @@ -107,7 +126,6 @@ const DatagridRow = ({ | |||
| className={classes.expandIconCell} | |||
| > | |||
| <ExpandRowButton | |||
| className={classes.expandButton} | |||
There was a problem hiding this comment.
this was causing the expand button to be always shown expanded (recent regression)
| resource, | ||
| id: String(id), | ||
| })} | ||
| {isValidElement(expand) |
There was a problem hiding this comment.
this is a temporary API. I'm not sure yet whether we should support components and elements everywhere, we'll see if profiling forces us to do that often.
| loaded: data.length !== 0 && !data.includes(undefined), | ||
| loading: ids.length !== 0, | ||
| loaded: | ||
| ids.length === 0 || |
There was a problem hiding this comment.
avoids showing the loader if there is nothing to load
fzaninotto
force-pushed
the
list_perf_improvements
branch
from
239e815
to
c87f129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various list perf improvements following a profiling sessions.
After an initial render of the datagrid from store, avoids a rerendering of each datagrid row once an unchanged response comes from the dataprovider.
Also, I believe we'll have to support Component injection in some places to avoid forced renders due to the fact that elements are always different.