Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Ensure DeleteButton is usable when record is not defined at mount time #3652

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Sep 5, 2019

We must not pass the action payload (the record and its identifier) at the hook declaration time to avoid errors for people using the button in a component which may not have the record loaded immediately (for exemple in the actions of an Edit component)

@djhi djhi added this to the 3.0.0 milestone Sep 5, 2019
@fzaninotto fzaninotto merged commit eefc2f2 into next Sep 5, 2019
@fzaninotto fzaninotto deleted the fix-delete-button branch September 5, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants