[RFR] Fix AutocompleteInput #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Nov 27, 2019
| @@ -328,13 +332,6 @@ const AutocompleteInput: FunctionComponent< | |||
| name={input.name} | |||
| InputProps={{ | |||
| inputRef: storeInputRef, | |||
| classes: { | |||
| root: classNames(classes.inputRoot, { | |||
There was a problem hiding this comment.
this was used to support both filled and standard variants. I'm afraid this change breaks that. Can you make sure the form displays correctly with <SimpleForm variant="standard">?
There was a problem hiding this comment.
Confirmed. It works by setting the variant on SimpleForm
fzaninotto
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4040
Many classes weren't used at all so I removed them.
Besides, while testing this on the simple example, I noticed that
SimpleFormIteratorwas adding adivbecause of theTransitionGroup. Thisdivwas inserted as the child ofulwhich breaks semantics and accessibility