Fix warning on catchall page due to improper sanitization in <NotFound> component.

[WiXSL]

This could happend from RoutesWithLayout.tsx.

...
<Route
    render={routeProps =>
        createElement(catchAll, {
            ...routeProps,
            title,
        })
    }
 />
...

[fzaninotto]

No, I don't think we should do that. If a route is to be used as a child of Route, it should expect these props to be passed.

[Luwangel]

Hi, thanks for your contribution :)

By reading your PR, I'm wondering what issue you try to fix. I think it's the warning on the NotFound page, but you didn't mention it in the description. Could you write what you try to achieve?

Regards,
Adrien

[WiXSL]

I tried to avoid the staticContext error thrown on NotFound component render.
The comment was to show the origin of the problem.

In the below sample, change the end of the url to something that doesn't exist like .../#/posts2
https://codesandbox.io/s/github/marmelab/react-admin/tree/master/examples/simple

In the console you'll see the error I tried to solve:

Warning: React does not recognize the `staticContext` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `staticcontext` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in div (created by NotFound)
    in Authenticated (created by NotFound)
    in NotFound (created by Context.Consumer)
    in Route (created by RoutesWithLayout)
    in Switch (created by RoutesWithLayout)
    in RoutesWithLayout (created by Context.Consumer)

[WiXSL]

@fzaninotto, The sanitizeRestProps function is called only to sanitize props to be applied to a div element inside NotFound component. Neither staticContext nor match should be applied to a div element.
Exactly the same thing is done in Layout.js already.

const NotFound = ({ className, classes: classesOverride, title, ...rest }) => {
    const classes = useStyles({ classes: classesOverride });
    const translate = useTranslate();
    useAuthenticated();
    return (
        <div
            className={classnames(classes.container, className)}
            {...sanitizeRestProps(rest)} // <-- Here
        >
    //...

[fzaninotto]

Sorry, I read too fast. Reopening.

[fzaninotto]

In the future, can you please post a more precise description of the bug you're trying to fix? Otherwise we have to guess and sometimes we guess wrong ;)

[WiXSL]

No problem, It was my fault, , I assume it was a trivial change to understand.

[fzaninotto]

Thanks!