Fix SimpleFormIterator for non empty array inputs #4535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
A warning
inside CssTransition shows if a record with none empty array input was loaded, and the animation of adding a new element is broken.
How to reproduce
It can be reproduced using any resource with ArrayInput and SimpleFormIterator:
For example you can add this input to the CategoryEdit form in the demo app:
Reason
nextId is a ref, it is an object like
{current: value}
.(nextId > 0)
will always be false because({} > 0)
is always false.Fix
Seems like
.current
is forgotten there.With this fix there is no warnings and animation works fine.