🏷 convert ra-language-english and ra-language-french to typescript #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Mar 23, 2020
fzaninotto
approved these changes
Mar 24, 2020
|
Awesome, thanks! |
|
No problem. Adding a ref to the issue: #4505 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self explanatory, summary of changes:
ra-core/src/i18n/TranslationMessages.tsthat contains the type. I tried with.d.tsas the extension, though tsc ignores this on build. Exported from pacakge.ra-18n-polyglotto accept this new type.ra-language-englishandra-language-frenchto typesript packages, added tsconfig.json, added build scripts and updated package.json to include relevant main, files, module and types.@fzaninotto please let me know if I have missed something.