Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning when leaving form with unsaved changes #4570

Merged
merged 15 commits into from
Mar 26, 2020
Merged

Add warning when leaving form with unsaved changes #4570

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3c8c837
Warn when unaved changes - but does not prevent leave
fzaninotto Mar 23, 2020
bb86dad
Form displays unsaved changes on cancel
fzaninotto Mar 23, 2020
ae6bd2e
Fix unit test
fzaninotto Mar 24, 2020
fbdd737
Fix bad cancel when coming from back button
fzaninotto Mar 24, 2020
58f78cd
Add doc
fzaninotto Mar 24, 2020
1e32b78
Make the feature opt-in
fzaninotto Mar 24, 2020
a75580d
expose hook publicly
fzaninotto Mar 24, 2020
09a2bd3
Fix typo
fzaninotto Mar 24, 2020
5f1d58f
Add unit test for hook
fzaninotto Mar 25, 2020
be37110
Document hook
fzaninotto Mar 25, 2020
1b5c2e5
Add message type
fzaninotto Mar 26, 2020
1f60d2c
Update packages/ra-core/src/form/useWarnWhenUnsavedChanges.tsx
fzaninotto Mar 26, 2020
09a01f7
Update packages/ra-core/src/form/useWarnWhenUnsavedChanges.spec.tsx
fzaninotto Mar 26, 2020
e39ba77
Update packages/ra-core/src/form/useWarnWhenUnsavedChanges.spec.tsx
fzaninotto Mar 26, 2020
ac55b9c
Fix typo
fzaninotto Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/ra-core/src/form/useWarnWhenUnsavedChanges.spec.tsx 
Co-Authored-By: Gildas Garcia <1122076+djhi@users.noreply.github.com>
  • Loading branch information
@fzaninotto @djhi
fzaninotto and djhi authored Mar 26, 2020
commit e39ba77024513568a5711e592d8d51e4e00157a9
2 changes: 1 addition & 1 deletion packages/ra-core/src/form/useWarnWhenUnsavedChanges.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe('useWarnWhenUnsavedChanges', () => {
getByText('Submitted');
});

it('should warn when leaving form with no unsaved changes', () => {
it('should warn when leaving form with unsaved changes', () => {
// mock click on "cancel" in the confirm dialog
window.confirm = jest.fn().mockReturnValue(false);
const { getByLabelText, getByText, queryByText } = render(<App />);
Expand Down