Avoid Multiple Notifications on Expired Session #4645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kmaschta
approved these changes
Apr 7, 2020
fzaninotto
requested changes
Apr 7, 2020
| // To avoid having multiple notifications, we first verify if | ||
| // a checkError promise is already ongoing | ||
| if (!authCheckPromise) { | ||
| authCheckPromise = authProvider |
There was a problem hiding this comment.
why do you store the entire Promise instead of just a boolean?
There was a problem hiding this comment.
Because this way, anyone interested by its result will receive it ?
There was a problem hiding this comment.
Hm, you're exposing a private API publicly without a real use case... I'm not comfortable with it.
There was a problem hiding this comment.
We were returning it before already. Nothing has changed. We just don't allow multiple simultaneous calls, that's all
There was a problem hiding this comment.
Gotcha, thanks for the explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.