Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ra-data-graphcool: Add ability to use pagination and orderBy in GET_MANY_REFERENCE #4778

Merged
merged 2 commits into from
May 25, 2020

Conversation

byymster
Copy link
Contributor

@byymster byymster commented May 6, 2020

According to documentation ReferenceManyField should have ability to have pagination and sorting.
For now ra-data-graphcool don't allow to do this.
This PR is adding this ability for ra-data-graphcool
The idea is "borrowed" from ra-data-graphql-simple

@fzaninotto
Copy link
Member

This is technically a new feature. Can you please PR against the next branch instead?

@byymster byymster changed the base branch from master to next May 8, 2020 08:02
@byymster
Copy link
Contributor Author

byymster commented May 8, 2020

@fzaninotto done

@byymster
Copy link
Contributor Author

@fzaninotto is it ok? do I need to create new PR? Please advice

Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 3.6.0 milestone May 25, 2020
@djhi djhi merged commit dd78d06 into marmelab:next May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants