Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to customize the notification element in the Login page #5630

Merged
merged 5 commits into from
Dec 11, 2020
Merged

Add ability to customize the notification element in the Login page #5630

merged 5 commits into from
Dec 11, 2020

Conversation

hieusmiths
Copy link
Contributor

We can't custom notification, so i decided to make this PR.

djhi
djhi approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@hieusmiths
Copy link
Contributor Author

Good catch, thanks!

💯

@fzaninotto
Copy link
Member

Hi, and thanks for your PR!

This is technically a new feature, so you should PR against the next branch rather than master.

@hieusmiths hieusmiths changed the base branch from master to next December 7, 2020 10:42
@hieusmiths
Copy link
Contributor Author

Hi, and thanks for your PR!

This is technically a new feature, so you should PR against the next branch rather than master.

Changed to next branch

@fzaninotto fzaninotto changed the title Fix can't custom notification in login page Add ability to customize the notification element in the Login page Dec 11, 2020
@fzaninotto fzaninotto merged commit 52eadc0 into marmelab:next Dec 11, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.11 milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11
Development

Successfully merging this pull request may close these issues.
3 participants
@hieusmiths @fzaninotto @djhi