Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix findDOMNode warning in StrictMode when using SimpleformIterator #5725

Merged
merged 1 commit into from
Jan 4, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/ra-ui-materialui/src/form/SimpleFormIterator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ const SimpleFormIterator: FC<SimpleFormIteratorProps> = props => {
defaultValue,
} = props;
const classes = useStyles(props);
const nodeRef = useRef(null);

// We need a unique id for each field for a proper enter/exit animation
// so we keep an internal map between the field position and an auto-increment id
Expand Down Expand Up @@ -184,6 +185,7 @@ const SimpleFormIterator: FC<SimpleFormIteratorProps> = props => {
<TransitionGroup component={null}>
{fields.map((member, index) => (
<CSSTransition
nodeRef={nodeRef}
key={ids.current[index]}
timeout={500}
classNames="fade"
Expand Down