Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ReferenceInput to let its child handle loading #5767

Merged
merged 5 commits into from
Jan 18, 2021
Merged

Refactor ReferenceInput to let its child handle loading #5767

merged 5 commits into from
Jan 18, 2021

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jan 13, 2021 •
edited
Loading

  • ReferenceInput
  • ReferenceArrayInput

@djhi djhi added the WIP Work In Progress label Jan 13, 2021
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Jan 15, 2021
@djhi djhi added this to the 3.12 milestone Jan 15, 2021
@fzaninotto
Copy link
Member

Does it fix #4992?

fzaninotto
fzaninotto requested changes Jan 17, 2021
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more tests for the Inputs you've modified (just like you did for SelectInput)

packages/ra-ui-materialui/src/input/AutocompleteInput.tsx Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit 9f6e81a into next Jan 18, 2021
@fzaninotto fzaninotto deleted the fix-reference-input-loading branch January 18, 2021 12:29
This was referenced Jan 25, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.12
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @fzaninotto