Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix outdated indonesian translation #5937

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

danangekal
Copy link
Contributor

@danangekal danangekal commented Feb 19, 2021

Hi Creators, Mainteners & Contributors,

I added document translation to rebuild a new Indonesian translation. I rebuilt with a typescript & fixed a missing type for the translated message 'ra.navigation.skip_nav'. I hope to merge & publish them.

Thanks.

@fzaninotto
Copy link
Member

Hi, and thanks for your patch.

I'd prefer if you updated the existing indonesian package. Did you try submitting a PR to their repository?

@danangekal
Copy link
Contributor Author

danangekal commented Feb 19, 2021

Hi @fzaninotto,

I have submitted for an update but there is no response. Because I needed to be able to solve problems with the application that I made, I finally decided to publish it myself. This is my submission link Enhancement convert to typescript with update translation indonesian

@fzaninotto
Copy link
Member

@danangekal In that case, let's wait a bit (let's say another week) for the initial package to be updated. It it's not, please update this PR to replace the link with the one of your repo. I prefer to have only one (maintained) translation per locale.

@fzaninotto
Copy link
Member

Hi, would you mind updating your PR to replace the outdated link with yours?

@danangekal
Copy link
Contributor Author

Hi, I've updated the outdated Indonesian translation link. Thank you for your attention @fzaninotto.

@fzaninotto fzaninotto merged commit 0ba943a into marmelab:master Mar 18, 2021
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.13.5 milestone Mar 18, 2021
@fzaninotto fzaninotto changed the title Add docs translation for new indonesian translation [Doc] Fix outdated indonesian translation Mar 18, 2021
@danangekal danangekal deleted the add-docs-new-translation-id branch March 29, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants