Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special-casing for accessing attributes of objects in a list #1188

Merged
merged 1 commit into from
Apr 7, 2019

Conversation

sloria
Copy link
Member

@sloria sloria commented Apr 7, 2019

This use case is met by fields.List(fields.Pluck(...))

#1187 (comment)

Copy link
Member

@lafrech lafrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@lafrech lafrech self-requested a review April 7, 2019 19:03
This use case is met by `fields.List(fields.Pluck(...))`

#1187 (comment)
@sloria sloria force-pushed the remove-container-attribute branch from 6c1c503 to 21c005d Compare April 7, 2019 19:06
@sloria sloria merged commit deabe89 into dev Apr 7, 2019
@sloria sloria deleted the remove-container-attribute branch April 7, 2019 19:07
@sloria sloria added this to the 3.0 milestone Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants