Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong get_declared_fields() param types #1222

Merged
merged 3 commits into from
May 21, 2019
Merged

Fix wrong get_declared_fields() param types #1222

merged 3 commits into from
May 21, 2019

Conversation

ccrisan
Copy link
Contributor

@ccrisan ccrisan commented May 21, 2019

It seems that SchemaMeta.get_declared_fields() takes arguments cls_fields and inherited_fields as list type. Yet the docstring params indicate their expected type as dict.

This PR adjusts the docstring declared types and corrects a couple of typos.

@sloria
Copy link
Member

sloria commented May 21, 2019

Thanks!

@sloria sloria merged commit 108c348 into marshmallow-code:dev May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccrisan @sloria