Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix propagation of "partial" to Nested containers #1230

Merged
merged 2 commits into from
Jun 9, 2019
Merged

Fix propagation of "partial" to Nested containers #1230

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41dc19f
Fix tests: Field._deserialize must accept **kwargs
lafrech Jun 5, 2019
fe85631
Fix propagation of "partial" to Nested containers
lafrech Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix tests: Field._deserialize must accept **kwargs
  • Loading branch information
@lafrech
lafrech committed Jun 5, 2019
commit 41dc19f123afb81105310de6de451235c306f711
4 changes: 2 additions & 2 deletions tests/test_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def test_error_raised_if_missing_is_set_on_required_field(self):

def test_custom_field_receives_attr_and_obj(self):
class MyField(fields.Field):
def _deserialize(self, val, attr, data):
def _deserialize(self, val, attr, data, **kwargs):
assert attr == 'name'
assert data['foo'] == 42
return val
Expand All @@ -61,7 +61,7 @@ class MySchema(Schema):

def test_custom_field_receives_data_key_if_set(self):
class MyField(fields.Field):
def _deserialize(self, val, attr, data):
def _deserialize(self, val, attr, data, **kwargs):
assert attr == 'name'
assert data['foo'] == 42
return val
Expand Down