Docs improvement: Move search box up the sidebar #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently on non-index pages, the search box is the last thing to appear in the sidebar. When viewing a page with a large "Table of Contents" section ([example](https://marshmallow.readthedocs.io/en/stable/marshmallow.fields.html)), the search box is very low on the page and readers must scroll down for a long time to find the search box. I recommend moving the search box up the sidebar so it appears '[above the fold](https://en.wikipedia.org/wiki/Above_the_fold)' on most resolutions. Let me know if you have any questions. Thanks!
lafrech
approved these changes
Nov 16, 2022
|
Feel free to merge whenever you have a chance - I don't have permission to merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on non-index pages, the search box is the last thing to appear in the sidebar. When viewing a page with a large "Table of Contents" section (example), the search box is very low on the page and readers must scroll down for a long time to find the search box. I recommend moving the search box up the sidebar so it appears 'above the fold' on most resolutions.
Let me know if you have any questions. Thanks!