Petit cleanup du code des verif_sorties #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnuria
commented
Oct 25, 2020
| <td><?= $d['last_hero_timestamp'] !== $d['timestamp'] ? $users[$d['id_last_hero']]['mail'] : '' ?></td> | ||
| <td><?= $d['last_hero_timestamp'] !== $d['timestamp'] ? $d['last_hero_timestamp'] : '' ?></td> | ||
| <td><a style="appearance: button" class="btn btn-warning btn-sm" href="../ifaces/modification_<?= $props['endpoint'] ?>.php?id=<?= $d['id'] ?>">Modifier</a></td> |
There was a problem hiding this comment.
Décalé le bouton a la fin parce-que sinon dès que on a une date de motif + éditeur c'est tout décalé, çà limite la casse.
| $req = $bdd->prepare("SELECT | ||
| $sortiesSQL, | ||
| sorties.id_type_sortie id_type, | ||
| type_sortie.nom, | ||
| -- localites.nom localisation, |
There was a problem hiding this comment.
Juste plus d'actualité
| @@ -226,14 +220,12 @@ function VerifSortiesTable(array $props) { | |||
| VerifSortiesTable(array_merge($base, [ | |||
| 'h3' => 'Dons simples :', | |||
| 'data' => $sortiesDon, | |||
| 'classe' => '' | |||
There was a problem hiding this comment.
Cette clef sert plus en fait :|
| ])); | ||
| ?> | ||
|
|
||
| <div class="panel panel-info"> |
There was a problem hiding this comment.
Un peu beaucoup de repetition entre les deux trucs je sais pas pourquoi on l'avais pas déjà nettoyé surement avant un truc coté serveur devait bloqué et fesait qu'on devait avoir DEUX codes différents d'UI pour les arguments d'url du <a>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On se répétais un peu et y'avais du code mort allez hop hop.