Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update golang.org/x/tools #17

Merged
merged 1 commit into from
Sep 21, 2022
Merged

fix(deps): update golang.org/x/tools #17

merged 1 commit into from
Sep 21, 2022

Conversation

kk-zu
Copy link
Contributor

@kk-zu kk-zu commented Aug 31, 2022 •
edited
Loading

I fixed issue #16.
I tried locally, issue's reproduction command was succeded.

mod upgrade --mod-name=github.com/google/go-github/v45 -t=47

@kk-zu
Copy link
Contributor Author

kk-zu commented Sep 21, 2022

@marwan-at-work Hi!
Could you please review PR?
Thank you for your cooperation.

marwan-at-work
marwan-at-work approved these changes Sep 21, 2022
View reviewed changes
Copy link
Owner

@marwan-at-work marwan-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, I'd missed the notification here.

@marwan-at-work marwan-at-work merged commit 19de07d into marwan-at-work:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwan-at-work marwan-at-work marwan-at-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kk-zu @marwan-at-work