Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Add Golang support #64

Merged
merged 4 commits into from
Sep 20, 2018
Merged

Add Golang support #64

merged 4 commits into from
Sep 20, 2018

Conversation

ladysamantha
Copy link
Contributor

Description

Add a golang section mirroring the functionality and configuration based on the spaceship theme https://denysdovhan.com/spaceship-prompt/docs/Options.html#go-golang

Motivation and Context

Greater parity with the ZSH theme. Also, the gopher is cute

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

screen shot 2018-09-20 at 09 27 00

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux

Checklist:

  • I have checked that no other PR duplicates mine
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Copy link
Owner

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting in the time to add Golang support! Your contribution is much appreciated. 🙌

I just have a couple quick comments, but otherwise your PR looks clean and well done. ✨

functions/__sf_section_golang.fish Outdated Show resolved Hide resolved
functions/__sf_section_golang.fish Outdated Show resolved Hide resolved
tests/__sf_section_golang.test.fish Show resolved Hide resolved
@matchai matchai added the Type: Enhancement New feature or request label Sep 20, 2018
@matchai
Copy link
Owner

matchai commented Sep 20, 2018

Everything looks good here.
Thanks again for your contribution! 😄

@matchai matchai merged commit 36f2652 into matchai:master Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants