Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php parser version 5 added into composer #274

Merged
merged 4 commits into from
May 14, 2024

Conversation

hkulekci
Copy link
Contributor

No description provided.

@hkulekci hkulekci marked this pull request as draft March 16, 2024 04:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (9b675df) to head (e89cbad).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #274   +/-   ##
=========================================
  Coverage     96.08%   96.08%           
  Complexity      194      194           
=========================================
  Files            36       36           
  Lines           639      639           
=========================================
  Hits            614      614           
  Misses           25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matchish
Copy link
Owner

The PHP versions 8.0.16 and 8.1 have failed. We should evaluate the following options:

Drop support for these versions.
Adjust the versions of our dependencies to maintain compatibility.

@mxp100
Copy link

mxp100 commented May 3, 2024

i think need support 8.1+ and drop supporting for 8.0.x

@matchish matchish marked this pull request as ready for review May 14, 2024 16:04
@matchish matchish merged commit 20612b6 into matchish:master May 14, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants