Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change if conditions order in soft deletes check for compatibility #282

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

rafaucau
Copy link
Contributor

I am integrating this package with Flarum, which is based on Laravel, but not everything is the same. E.g. models do not have the usesSoftDelete method, which causes errors. A simple swap of the order of the checks solves this problem.
Context: clarkwinkelmann/flarum-ext-scout#3 (comment)

This should not change the behavior of this package, and it will help in my case.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (3a05178) to head (666addd).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #282   +/-   ##
=========================================
  Coverage     95.99%   95.99%           
  Complexity      194      194           
=========================================
  Files            36       36           
  Lines           624      624           
=========================================
  Hits            599      599           
  Misses           25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matchish
Copy link
Owner

Hi, thanks for the PR! Could you update the changelog.md?
suggested version is 7.6.2

@rafaucau
Copy link
Contributor Author

@matchish done

@matchish matchish merged commit 94365ad into matchish:master Jun 24, 2024
5 checks passed
@rafaucau rafaucau deleted the soft_delete_condition branch June 24, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants