Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.2.4] MTableToolbar no longer styleable. #362

Closed
MatthijsKok opened this issue Oct 7, 2021 · 2 comments
Closed

[0.2.4] MTableToolbar no longer styleable. #362

MatthijsKok opened this issue Oct 7, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@MatthijsKok
Copy link

Since upgrading to the @next branch, our custom toolbar styling no longer shows.
After looking through the sourcecode, it appears impossible to add styles to the underlying toolbar component.
We also could not find any documentation about this.

Our previous solution:

const CustomToolbar = withStyles(theme => ({
    root: {
        backgroundColor: theme.palette.grey[50],
        borderTop: `4px solid ${theme.palette.primary.light}`,
        borderRadius: `${theme.shape.borderRadius}px ${theme.shape.borderRadius}px 0 0`,
    },
}))(MTableToolbar);

What we would like to have:

const CustomToolbar = styled(MTableToolbar)(({ theme }) => ({
    backgroundColor: theme.palette.grey[50],
    borderTop: `4px solid ${theme.palette.primary.light}`,
    borderRadius: `${theme.shape.borderRadius}px ${theme.shape.borderRadius}px 0 0`,
}))
@MatthijsKok MatthijsKok added the bug Something isn't working label Oct 7, 2021
@Domino987
Copy link
Contributor

Yes, that should obliviously be working. We will fix that ASAP.

se-neax added a commit to se-neax/core that referenced this issue Oct 7, 2021
Domino987 pushed a commit that referenced this issue Oct 7, 2021
* Fix #362:MTableToolbar style

* added PropTypes for className in MTableToolbar
@Domino987
Copy link
Contributor

Will be fixed with the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants